paul/opium
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Replace ad-hoc isLeft by import from Data.Either

Browse Source
This commit is contained in:
Paul Brinkmeier 2024-04-11 18:56:58 +02:00
parent 3a5488c89d
commit 20d150d12c
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Database/PostgreSQL/Opium.hs
View File

@ -67,8 +67,9 @@ execParams conn query params = do
Nothing -> pure result Nothing -> pure result
Just message -> except $ Left $ ErrorInvalidResult status $ Encoding.decodeUtf8 message Just message -> except $ Left $ ErrorInvalidResult status $ Encoding.decodeUtf8 message
-- The order of the type parameters is important, because it is more common to use type applications for providing the row type.
fetch fetch
:: forall a b. (ToParamList a, FromRow b) :: forall b a. (ToParamList a, FromRow b)
=> Connection => Connection
-> Text -> Text
-> a -> a

5
test/Database/PostgreSQL/OpiumSpec.hs
View File

@ -7,6 +7,7 @@
module Database.PostgreSQL.OpiumSpec (spec) where module Database.PostgreSQL.OpiumSpec (spec) where
import Data.ByteString (ByteString) import Data.ByteString (ByteString)
import Data.Either (isLeft)
import Data.Functor.Identity (Identity (..)) import Data.Functor.Identity (Identity (..))
import Data.Proxy (Proxy (..)) import Data.Proxy (Proxy (..))
import Data.Text (Text) import Data.Text (Text)
@ -53,10 +54,6 @@ newtype Only a = Only
instance Opium.FromField a => Opium.FromRow (Only a) where instance Opium.FromField a => Opium.FromRow (Only a) where
isLeft :: Either a b -> Bool
isLeft (Left _) = True
isLeft _ = False
shouldHaveColumns shouldHaveColumns
:: Opium.FromRow a :: Opium.FromRow a
=> Proxy a => Proxy a